-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SNAX specific events to the tracing script #254
Open
AntonLydike
wants to merge
13
commits into
main
Choose a base branch
from
josse+anton/la-pazzia-perfetto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pdb can not debug with ProcessPoolExecutor, this adds an extra mode that runs sequentially for debugging
JosseVanDelm
force-pushed
the
josse+anton/la-pazzia-perfetto
branch
from
November 14, 2024 17:35
a40aeae
to
a329a90
Compare
JosseVanDelm
requested review from
JosseVanDelm and
jorendumoulin
and removed request for
JosseVanDelm
November 14, 2024 17:55
@AntonLydike I rebased this, found a few errors, and added some functionality |
|
||
# if state is None, check if we are setting up, if so, switch state to "setting up" | ||
if self.state is None: | ||
if (ins.csr in self.fields) or (ins.csr in self.launch_fields): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bit wrong before 😄 :
if ins.csr in self.fields or self.launch_fields:
Which is almost always true 😅
@AntonLydike I can not request a review from you, but I'd appreciate it if you could have a look at this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SNAX specific event tracer to the trace_to_perfetto utilty:
The following three events are discerned to produce those traces:
- starts at the first CSR write to a config register
- ends after all launch fields have been written to
- records the number of setup instructions executed
- starts immediately after the "pre-launch" event
- ends on the second "write 0 to launch addr"
- starts on the first read from the barrier address
- ends when that read return 1
This should be general enough to support any SNAX accelerator, although I (@JosseVanDelm) am not entirely sure how to verify that in CI.
The utility was already useable standalone, but this patch makes it more difficult to specify a bunch of options that are invalid.
--sequential
to run the tracer in sequential mode, which is useful for debugging with pdb.--accelerator
to specify a SNAX accelerator in order to activate the SNAX specific event tracer (this functionality is also now available forprocess_traces
inSNAXBenchmark
.--annotate-kernels
and the tool will warn you if you do not specify the--elf
-file and the--addr2line
executableImportant note:
In perfetto you might want to change your time format to be anything but timecode, because otherwise it seems to mess up the numbers (not sure why, and also not sure how we can change that default behaviour)