Optimize ReaderWriter #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rgantonio If you are free, please check if the critical path in control path (valid / ready hand shaking signal) deteriorates with this improvements 😊😊 |
xiaoling-yi
approved these changes
Sep 24, 2024
rgantonio
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Hmm please don't put backups in the repo. Leave them be in the local computers.
|
Also, did you trace or check in Chisel if it fixes the long path? |
rgantonio
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the following in ReaderWriter:
Replace the spatialAddrGen with full adder implementationReplace all buffers with pipe buffers (except the scalatest one)