Increasing spatial dim of C32 and D32 in GeMMX to 2 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoling-yi
changed the title
|
Thanks @xiaoling-yi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we increase the spatial dimension of the C32 and D32 ports in GeMMX to 2 (previously it was 1).
With this, we add an extra stride in the spatial address generation for C32 and D32 (now can jump at 2 elements and row granularity), thus enabling more data layout opportunities for reducing the bank conflict.
@jorendumoulin @JosseVanDelm , please have a look at it, now we have two extra spatial strides CSRs. Please let me know if there is anything unclear.