Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for constrained temporal mapping #82

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JonasCrols
Copy link
Contributor

Add testcases where temporal mappings are used which make use of wild cards. this tests the new feature where only parts of the temporal mappings can be specified, and the other parts will be filled in by the LOMA engine

@JonasCrols
Copy link
Contributor Author

opened as draft as I don't know yet if this is the proper way to test

@JonasCrols JonasCrols marked this pull request as ready for review September 24, 2024 13:49
@asyms
Copy link
Contributor

asyms commented Sep 27, 2024

@JonasCrols it seems like there is still one layer (Layer29) which is failing? Was this the layer that was giving you problems before?

@JonasCrols
Copy link
Contributor Author

JonasCrols commented Sep 30, 2024

@JonasCrols it seems like there is still one layer (Layer29) which is failing? Was this the layer that was giving you problems before?

that's weird, locally all tests passed. will look into it right away. Also this layer is a different one than the one giving problems before. This mapping never even had any problems

@JonasCrols
Copy link
Contributor Author

JonasCrols commented Sep 30, 2024

@JonasCrols it seems like there is still one layer (Layer29) which is failing? Was this the layer that was giving you problems before?

Hi @asyms , I already found that it works fine with the resnet18.onnx file, but not with the resnet18.yaml. Locally I only tested the onnx file as I thought the two were identical, is this not the case? if not, than the problem is probably the same as I had before and the provided constraints are impossible. I have constraints that work for the onnx, and other constraints that work for the yaml. but none work for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants