Remove some bindgen layout tests to more freely enable multiple archs #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dginev
force-pushed
the
drop-bindgen-layout-tests
branch
from
0d9395a
to
54221d4
Compare
dginev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to take the easy way out and simply drop the architecture-specific layout tests that bindgen provided for free.
If contributors take multi-architecture support seriously and stumble on this PR, they should feel welcome to create a more elaborate testing framework, maybe even moving out the low-level bindgen bits into a separate crate, as per #76 .
For now I don't want to needlessly inhibit uses on other architectures, while I also can't commit any time to properly add support for it, so seeking some middle ground...