Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WearOS version #218

Open
wants to merge 8 commits into
base: kmp
Choose a base branch
from
Open

WearOS version #218

wants to merge 8 commits into from

Conversation

rezazarchi
Copy link

related to issue #176

@rezazarchi rezazarchi marked this pull request as draft July 14, 2024 11:17
@rezazarchi
Copy link
Author

Hey @Kaaveh
I've added a new Android application module for Wear OS! I've included all the necessary dependencies and set up a basic MainActivity (it's empty for now).

I'd love to hear your thoughts on this initial setup. Please let me know if you have any feedback. Thanks!

@Kaaveh Kaaveh self-requested a review July 15, 2024 02:36
Kaaveh
Kaaveh previously approved these changes Jul 15, 2024
View reviewed changes
@Kaaveh Kaaveh added the enhancement New feature or request label Jul 15, 2024
@Kaaveh
Copy link
Owner

Kaaveh commented Jul 15, 2024

Hi @rezazarchi
It's amazing! Please continue.

@rezazarchi rezazarchi requested a review from Kaaveh August 3, 2024 07:01
@rezazarchi
Copy link
Author

rezazarchi commented Aug 3, 2024 •
edited
Loading

I changed modules structure to remove all WearOS-related dependencies from the current modules. We now have separated design, navigation, and UI modules for the WearOS version.

I added the remaining implementations for showing the list and details. However, there's still some work to do:

  • QuadLineChart still needs optimization for Wear UI. I couldn't resolve this issue yet.
  • We might improve the navigation to the details screen. I used navController.navigate(***) for this, but your previous solution for the details screen in the app module was slightly different.
  • The favorite feature hasn't been implemented yet.
  • Swipe functionality for each item hasn't been implemented yet.
  • The module structure might need review and refactoring if necessary.
  • Unit and UI tests haven't been implemented yet.

Kaaveh
Kaaveh previously approved these changes Aug 3, 2024
View reviewed changes
Copy link
Owner

@Kaaveh Kaaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@rezazarchi rezazarchi marked this pull request as ready for review September 19, 2024 08:48
Kaaveh
Kaaveh requested changes Sep 20, 2024
View reviewed changes
app-watch/app/proguard-rules.pro
@@ -0,0 +1,21 @@
# Add project specific ProGuard rules here.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this file be deleted?

app-watch/navigation/src/main/AndroidManifest.xml
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file can be deleted.

app-watch/ui/src/main/AndroidManifest.xml
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file can be deleted.

gradle/libs.versions.toml
@@ -2,6 +2,7 @@
projectApplicationId = "ir.composenews"
projectVersionName = "1.0.0"
projectMinSdkVersion = "23"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the build issue come from here! 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaaveh Kaaveh Kaaveh requested changes

@VahidGarousi VahidGarousi Awaiting requested review from VahidGarousi

Requested changes must be addressed to merge this pull request.

Assignees

@rezazarchi rezazarchi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rezazarchi @Kaaveh