Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check to determine if we need to pop from git stash #7

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

ju-Skinner
Copy link
Collaborator

@ju-Skinner ju-Skinner commented Dec 13, 2023

Urgent

I want to deploy a release candidate so I can confirm that the PIne release workflow works as intended. If I don't merge this, then I will have to wait for the next nightly build.

Description

Adds a check for statusResults.files which assists in determining if there were SVG changes.

The main purpose of these changes is in times when we want to invoke a Manual deployment that involves code changes, but not icon changes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for pine-icons ready!

Name Link
🔨 Latest commit ee97daf
🔍 Latest deploy log https://app.netlify.com/sites/pine-icons/deploys/6579cfbb2fee290008c47c97
😎 Deploy Preview https://deploy-preview-7--pine-icons.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ju-Skinner ju-Skinner self-assigned this Dec 13, 2023
@ju-Skinner ju-Skinner added the bug Something isn't working label Dec 13, 2023
Copy link
Contributor

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ju-Skinner ju-Skinner merged commit ffc5cc9 into next Dec 13, 2023
13 checks passed
@ju-Skinner ju-Skinner deleted the fix/update-icon-version-script branch December 13, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants