Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sage-component): add to the list of components on the rails doc site #1773

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

ju-Skinner
Copy link
Collaborator

Description

With the addition of a new prop to SageComponent, we need the ability to share the details with our customers. This will add the base SageComponent to the Rails doc site.

Screenshots

image

Testing in sage-lib

  1. Navigate to the Rails doc site e.g http://localhost:4000
  2. Click on "Components", Sage Component should be the first component in the list. This was done intentionally since it serves as the base component for all Rails Sage components.
  3. Click on the Props tab, you should see the same details as the screenshot above.

Testing in kajabi-products

No Impact

Related

@ju-Skinner ju-Skinner requested a review from a team August 1, 2023 10:51
@ju-Skinner ju-Skinner self-assigned this Aug 1, 2023
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM! This is a great addition, thanks for adding!

@pixelflips pixelflips requested a review from a team August 1, 2023 17:29
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Additions

@ju-Skinner ju-Skinner merged commit 81711ae into develop Aug 4, 2023
1 check passed
@ju-Skinner ju-Skinner deleted the docs/add-sage-component-to-docs branch August 4, 2023 15:05
@ju-Skinner ju-Skinner mentioned this pull request Aug 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants