Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update documentation for Icons #1928

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Docs: update documentation for Icons #1928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/app/views/examples/components/alert/_props.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<td><%= md('`icon_name`') %></td>
<td><%= md('Icon defaults are provided. Icons can also be customized with this property.') %></td>
<td><%= md('String') %></td>
<td><%= md('See Sage Icons.') %></td>
<td><%= md('See Icons.') %></td>
</tr>
<tr>
<td><%= md('`primary_action`') %></td>
Expand Down
2 changes: 1 addition & 1 deletion docs/app/views/examples/components/form_input/_props.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</tr>
<tr>
<td><%= md('`icon`') %></td>
<td><%= md('Adds a static icon for visual context. See Sage Icons under "Design."') %></td>
<td><%= md('Adds a static icon for visual context. See Icons under "Foundations."') %></td>
<td><%= md('String') %></td>
<td><%= md('`nil`') %></td>
</tr>
Expand Down
2 changes: 1 addition & 1 deletion docs/app/views/examples/components/hint/_props.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
<td><%= md('`icon`') %></td>
<td><%= md('Icon to be displayed before the text content.') %></td>
<td><%= md('String') %></td>
<td><%= md('See Sage Icons.') %></td>
<td><%= md('See Icons.') %></td>
</tr>
4 changes: 2 additions & 2 deletions docs/app/views/examples/components/icon/_props.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@
</tr>
<tr>
<td><%= md('`color`') %></td>
<td><%= md('Which color to use to render the icon. See Sage Colors under "Design."') %></td>
<td><%= md('Which color to use to render the icon. See Sage Colors under "Foundations."') %></td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad to see you added this in. It was a request in Sage Support yesterday.

<td><%= md('Color slider values such as "primary", "prmary-100".') %></td>
<td><%= md('`nil`') %></td>
</tr>
<tr>
<td><%= md('`icon`') %><%= sage_component SageBadge, { color: "published", value: "required" } %></td>
<td><%= md('
Which icon to display. See Sage Icons under "Figma Design."
Which icon to display. See Icons under "Foundations."
Note: `null` is also available to place an empty space icon
') %></td>
<td><%= md('`String` for desired icon.') %></td>
Expand Down
2 changes: 1 addition & 1 deletion docs/app/views/examples/components/icon_card/_props.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<td><%= md('`icon`') %><%= sage_component SageBadge, { color: "published", value: "required" } %></td>
<td><%= md('The Sage icon to show inside the card.') %></td>
<td><%= md('`String`') %></td>
<td><%= md('See Sage Icons.') %></td>
<td><%= md('See Icons.') %></td>
</tr>
<tr>
<td><%= md('`label`') %></td>
Expand Down
4 changes: 2 additions & 2 deletions docs/app/views/examples/components/property/_props.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<tr>
<td><%= md('`icon`') %></td>
<td><%= md('The Sage icon to show in the property.') %></td>
<td><%= md('The icon to show in the property.') %></td>
<td><%= md('String') %></td>
<td><%= md('See Sage Icons.') %></td>
<td><%= md('See Icons.') %></td>
</tr>
<tr>
<td><%= md('`value`') %></td>
Expand Down
2 changes: 1 addition & 1 deletion docs/app/views/examples/components/status_icon/_props.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<td><%= md('`icon`') %><%= sage_component SageBadge, { color: "published", value: "required" } %></td>
<td><%= md('The icon to be display.') %></td>
<td><%= md('String') %></td>
<td><%= md('See Sage Icons.') %></td>
<td><%= md('See Icons.') %></td>
</tr>
<tr>
<td><%= md('`value`') %><%= sage_component SageBadge, { color: "published", value: "required" } %></td>
Expand Down
Loading