authentication #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo corrections in app.js reorganization of directories auth shema auth middleware auth controllers suth routers
KamilMr
approved these changes
Jul 28, 2024
| const { email, password } = req.body; | ||
| const user = await Users.findOne({ email }) | ||
|
|
||
| const { error } = schemaLogin.validate({ email, password }); |
There was a problem hiding this comment.
Najpierw validacja potem zapytanie do bazy danych, ok? Tak we wszystkich kontrolerach gdzie robisz sprawdzenie danych. Najpierw trzeba zobaczyć czy są poprawne, a dopiero potem robić operacje na bazie danych. Czy widzisz co możesz zmienić? :)
There was a problem hiding this comment.
Tu już mi się chyba udało poprawki wprowadzić. :) dzięki
|
|
||
| if (isPasswordCorrect) { | ||
| const payload = { id: user._id, } | ||
| const token = jwt.sign( |
There was a problem hiding this comment.
Coś jest nie tak z indentacją, widzisz?
There was a problem hiding this comment.
Wiem, że nie działa mi to najlepiej, ale nie za bardzo potrafię dojść do tego co tu zepsułem.
middleware/jwt.js
Outdated
| session: false, | ||
| }, | ||
| (err, user) => { | ||
| if(!user || err) { |
There was a problem hiding this comment.
Suggested change
| if(!user || err) { | |
| if(!user || err || !user.token) { |
Trzeba jeszcze zobaczyć czy token jest null czy nie
KamilMr
requested changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typo corrections in app.js
reorganization of directories
auth shema
auth middleware
auth controllers
auth routers
Mam problem z Logout I current.
Nie rozumiem dlaczego nie znajduje mi wskazywanego id, tym bardziej, że początkowo mi zadziałało, ale teraz nie potrafię znaleźć błędu.