feat(viz): add ability to insert branch steps

[kahboom]

This PR adds the ability to insert a step in between two branch steps. Resolves #1114.

Changes

• Add check in mini catalog to validate inserting branch steps
• Add handling in mini catalog step selection for branch steps
• Enable insert edge type for branch steps
• Extract insertStep logic into its own testable function
• Improve query params for API request to be more accurate with source/target step
• Improve typings

Screenshots

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Merging #1140 (198a753) into main (8454fd9) will decrease coverage by 0.12%.
The diff coverage is 29.03%.

@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
- Coverage   48.43%   48.31%   -0.12%     
==========================================
  Files          51       51              
  Lines        1627     1631       +4     
  Branches      364      368       +4     
==========================================
  Hits          788      788              
- Misses        793      798       +5     
+ Partials       46       45       -1     

Impacted Files	Coverage Δ
src/components/PlusButtonEdge.tsx	32.43% <20.83%> (-15.40%)	⬇️
src/store/integrationJsonStore.tsx	22.36% <33.33%> (ø)
src/services/visualizationService.ts	85.78% <66.66%> (+0.14%)	⬆️
src/services/validationService.ts	9.52% <100.00%> (ø)
src/components/VisualizationStepViews.tsx	10.41% <0.00%> (-0.58%)	⬇️
src/components/Visualization.tsx	40.74% <0.00%> (+3.14%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[mmelko]

If only one step is left in the branch, I'm not able to add any step into that branch anymore: see:

[kahboom]

@mmelko but how would you know whether the user wants to add a step to the branch or to the main integration? for this thing I think we would need to have a design review and also be working on 1) showing which steps are part of a branch #1133, and 2) building branches visually #786.

[mmelko]

So the simplest would be to have 2x + one in the branch and second at the integration level before the first step of the first step after branches (filter step in this cas)

[kahboom]

I don't see a filter step, but I think I know what you mean. But that's why I mentioned prepend step would need to be supported, and right now it's not. To me that should be in a separate PR.

Actually I'm thinking about it and even if we allowed appending/prepending steps in a branch, it will look really weird to users until we solve #1133 , because it will have two + buttons in between two steps, the user won't know the difference between those buttons, or know that one is to add inside of a branch and the other for outside of the branch.