Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Add new e2e Kaoto editor tests #1384

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Mar 3, 2023

Added new Kaoto editor tests - related to #1297

Code editor actions

  • User adds, edits, and removes a step from the YAML*
  • User adds and removes a branch from the YAML
  • User undoes a change they saved, syncs with canvas*
  • User clears the state of the code editor, syncs with canvas*
  • User uploads YAML file, syncs with canvas
  • User downloads YAML file, syncs with canvas

The item User clears the state of the code editor, syncs with canvas is blocked ATM by #1383
The second missing item @kahboom - User downloads YAML file, syncs with canvas - I may have not understood this correctly, but the download doesn't affect the editor, so is this test necessary?

@tplevko tplevko requested a review from a team March 3, 2023 16:31
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1384 (a646055) into main (68077c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1384   +/-   ##
=======================================
  Coverage   52.88%   52.88%           
=======================================
  Files          56       56           
  Lines        1908     1908           
  Branches      435      435           
=======================================
  Hits         1009     1009           
  Misses        851      851           
  Partials       48       48           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kahboom
Copy link
Contributor

kahboom commented Mar 3, 2023

The second missing item @kahboom - User downloads YAML file, syncs with canvas - I may have not understood this correctly, but the download doesn't affect the editor, so is this test necessary?

@tplevko that can be ignored/removed, I think I have just included this for completeness and maybe manual testing 🙂

@kahboom kahboom merged commit 0c89bc8 into KaotoIO:main Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants