This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
chore: StepsService cleanup #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a byproduct of another investigation, there some small cosmetic improvements over the StepsService The changes are: * Rename then saveConfig parameter to updateStepParams to (hopefully) make it easier to understand where this parameter goes * Replace .map() call with a .forEach to avoid creating a new array * Type the buildStepSchemaAndModel method parameters
|
Kudos, SonarCloud Quality Gate passed!
|
igarashitm
approved these changes
Mar 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a byproduct of another investigation, there are some small cosmetic improvements over the StepsService
Changes
saveConfigparameter to updateStepParams to (hopefully) make it easier to understand where this parameter goes.map()call with a.forEachto avoid creating a new arraybuildStepSchemaAndModelmethod parameters