Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Update E2E 10-branching_actions tests #1516

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

unsortedhashsets
Copy link
Member

This PR updates tests scenarios for branching actions and nested branching actions from through canvas to through choice extension

  • Check that tab/button is disabled
  • Сhoice-extension workaround is used where it is possible (delete/append/prepend/step_actions)
  • In general 10-branching_actions tests were refactored

Relates:

@unsortedhashsets unsortedhashsets requested a review from a team March 20, 2023 16:01
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.2% 3.2% Duplication

Copy link
Contributor

@kahboom kahboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @unsortedhashsets !

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1516 (16d48f9) into main (b1c6b90) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1516   +/-   ##
=======================================
  Coverage   56.46%   56.46%           
=======================================
  Files          64       64           
  Lines        2019     2019           
  Branches      464      464           
=======================================
  Hits         1140     1140           
  Misses        833      833           
  Partials       46       46           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kahboom kahboom merged commit c93c6e1 into KaotoIO:main Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants