This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(step-details): Step's details panel is referencing an old value #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1580 +/- ##
=======================================
Coverage ? 57.01%
=======================================
Files ? 68
Lines ? 2054
Branches ? 470
=======================================
Hits ? 1171
Misses ? 839
Partials ? 44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
unsortedhashsets
previously approved these changes
Mar 29, 2023
apupier
previously approved these changes
Mar 29, 2023
|
@lordrip only thing is that you have some dependency conflicts in |
Currently, when opening the step’s details tab, it’s not referencing the most recent values but keeping the previous values from a previous step. This generates unintentional changes to a different step than the user is intending to. This situation was caused because of the addition of a `debounce` function with the intention to only save the [form’s values after the user’s input stopped](#1537). The problem was that the `debounce` function was causing to capture the form’s value from the previous render, hence saving the wrong values to the previous step. To avoid this situation in the future, the saveConfig function now receives the original step and the new values. - Changes * Refactor saveConfig callback to receive the original step as parameter * Replace lodash' debounce function with useDebounceCallback() * Increase the debounce timer from 500ms to 1s * Update onChangeModel signature to (configuration: Record<string, unknown>, isValid: boolean) to reflect more accurately the intended parameters. * Remove the lodash.debounce dependency since is no longer required fix: #1561
lordrip
dismissed stale reviews from kahboom, apupier, and unsortedhashsets
via
119fbc8
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when opening the step’s details tab, it’s not referencing the most recent values but keeping the previous values from a previous step.
This generates unintentional changes to a different step than the user is intending to.
This situation was caused because of the addition of a
debouncefunction with the intention to only save the form’s values after the user’s input stopped.The problem was that the
debouncefunction was causing to capture the form’s value from the previous render, hence saving the wrong values to the previous step.To avoid this situation in the future, the saveConfig function now receives the original step and the new values.
Changes
saveConfigcallback to receive the original step as a parameteruseDebounceCallback()debouncetimer from500msto1sonChangeModelsignature to(configuration: Record<string, unknown>, isValid: boolean)to reflect more accurately the intended parameters.lodash.debouncedependency since is no longer requiredBefore
Screencast.from.2023-03-29.07-46-54.webm
After
Screencast.from.2023-03-29.07-50-39.webm
fix: #1561