Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

nitpick: Show active/inactive toolbar icons #1652

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Apr 13, 2023

fixes #1283

Screen Shot 2023-04-17 at 10 51 54 am

Screen Shot 2023-04-17 at 10 52 02 am

@pnaik1 pnaik1 requested a review from a team April 13, 2023 14:40
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1652 (af75894) into main (9f3fe76) will decrease coverage by 0.15%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
- Coverage   65.72%   65.58%   -0.15%     
==========================================
  Files          71       71              
  Lines        2048     2057       +9     
  Branches      467      469       +2     
==========================================
+ Hits         1346     1349       +3     
- Misses        660      666       +6     
  Partials       42       42              
Impacted Files Coverage Δ
src/components/KaotoToolbar.tsx 39.20% <40.00%> (-0.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -47,18 +47,19 @@ import { useCallback, useEffect, useState } from 'react';

export interface IKaotoToolbar {
toggleCatalog: () => void;
leftDrawerExpanded:boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick, but can you add a space here for better formatting? Like leftDrawerExpanded: boolean, please? Thanks!

@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@kahboom kahboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @pnaik1 !

@kahboom kahboom merged commit 2ae52d8 into KaotoIO:main Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Show active/inactive toolbar icons
2 participants