Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

chore: Add id and integrationId properties #1727

Merged
merged 2 commits into from
May 4, 2023
Merged

chore: Add id and integrationId properties #1727

merged 2 commits into from
May 4, 2023

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented May 3, 2023

Context

Within the scope of supporting multiple routes, a way to identify them is required and for that matter, this commit adds:

  • id property to the IIntegration interface
  • integrationId property to the IStepProps interface
  • Update fetchIntegrationJson function to return IIntegration[]

It also updates all related stubs, mocks, and test to support the newly added properties.

relates: 801

@lordrip lordrip requested a review from a team May 3, 2023 14:13
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1727 (56bf6ea) into main (ffac4cf) will increase coverage by 0.06%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
+ Coverage   66.82%   66.89%   +0.06%     
==========================================
  Files          72       72              
  Lines        2077     2075       -2     
  Branches      471      470       -1     
==========================================
  Hits         1388     1388              
+ Misses        648      645       -3     
- Partials       41       42       +1     
Impacted Files Coverage Δ
src/api/apiService.ts 29.67% <0.00%> (+0.63%) ⬆️
src/components/SourceCodeEditor.tsx 54.21% <0.00%> (ø)
src/components/Visualization.tsx 65.07% <0.00%> (ø)
src/store/data/branchSteps.ts 100.00% <ø> (ø)
src/store/data/steps.ts 100.00% <ø> (ø)
src/stubs/debezium-mongodb.step.ts 100.00% <ø> (ø)
src/stubs/integration-steps.ts 100.00% <ø> (ø)
src/stubs/steps.ts 100.00% <ø> (ø)
src/types/index.ts 100.00% <ø> (ø)
src/store/integrationJsonStore.tsx 92.77% <100.00%> (ø)

Within the scope of supporting multiple routes, a way to identify
them is required and for that matter this commit adds:

* 'id' property to the IIntegration interface
* 'integrationId' property to the IStepProps interface

It also updates all related stubs, mocks and test to
support the newly added properties.

relates: [801](#801)
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@lordrip lordrip merged commit d2050dd into KaotoIO:main May 4, 2023
@lordrip lordrip deleted the chore/add-id-for-integrations branch May 8, 2023 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants