Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

feat(flows): Add mechanism to navigate between flows #1880

Merged
merged 1 commit into from
Jun 1, 2023
Merged

feat(flows): Add mechanism to navigate between flows #1880

merged 1 commit into from
Jun 1, 2023

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented May 31, 2023

Context

Currently, all existing flows are being shown. This behavior is not useful when there are many flows at the same time or somewhat complex flows.

In addition to that, there's no mechanism to delete an existing flow.

Changes

This pull request provides a way to toggle the visibility of individual flows, by leveraging a flows list that also provides the functionality of deleting individual flows.

Notes

Some tests are still pending.

relates to: #801

@lordrip lordrip requested a review from a team May 31, 2023 15:14
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1880 (6d26cab) into main (ac1a3c3) will increase coverage by 0.89%.
The diff coverage is 89.14%.

❗ Current head 6d26cab differs from pull request most recent head 3c7eb3b. Consider uploading reports for the commit 3c7eb3b to get more accurate results

@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
+ Coverage   57.93%   58.82%   +0.89%     
==========================================
  Files          70       72       +2     
  Lines        2439     2538      +99     
  Branches      566      573       +7     
==========================================
+ Hits         1413     1493      +80     
- Misses        976      994      +18     
- Partials       50       51       +1     
Impacted Files Coverage Δ
src/components/Extension.tsx 23.07% <ø> (-5.50%) ⬇️
src/components/KaotoDrawer.tsx 83.33% <ø> (-1.29%) ⬇️
src/layout/ErrorBoundary.tsx 20.00% <ø> (-7.28%) ⬇️
src/components/Visualization.tsx 67.10% <62.96%> (+1.95%) ⬆️
src/components/PlusButtonEdge.tsx 34.21% <66.66%> (+1.77%) ⬆️
src/components/VisualizationStepViews.tsx 68.67% <72.72%> (-0.95%) ⬇️
src/components/Flows/FlowsMenu.tsx 90.47% <90.47%> (ø)
src/services/visualizationService.ts 82.98% <91.17%> (+0.45%) ⬆️
src/components/DSL/DSLSelector.tsx 100.00% <100.00%> (ø)
src/components/DSL/NewFlow.tsx 100.00% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

igarashitm
igarashitm previously approved these changes May 31, 2023
Currently, all existing flows are being shown. This behavior
is not useful when there are many flows at the same time or
somewhat complex flows.

In addition to that, there's no mechanism to delete an existing
flow.

This commit provides a way to toggle the visibility of individual
flows, by leveraging a flows list that also provides the functionality
of deleting individual flows.

relates to: #801
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.1% 10.1% Duplication

@lordrip lordrip merged commit e5fe329 into KaotoIO:main Jun 1, 2023
@lordrip lordrip deleted the feat/navigate-multi-routes branch June 1, 2023 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants