Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

chore(viz): improve branching types and check for merging edges back #986

Merged
merged 3 commits into from
Dec 2, 2022
Merged

chore(viz): improve branching types and check for merging edges back #986

merged 3 commits into from
Dec 2, 2022

Conversation

kahboom
Copy link
Contributor

@kahboom kahboom commented Dec 1, 2022

Changes

  • Improves typings for branchInfo properties
  • Re-implements check for either 1) end of branch steps array OR 2) steps of type END, to determine whether to merge a branch back
  • Disables draggability of all nodes again
  • Removes some unused code

@kahboom kahboom requested a review from a team December 1, 2022 11:12
@kahboom kahboom changed the title chore(viz): enhancements chore(viz): improve branching types and check for merging edges back Dec 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mmelko
mmelko approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@mmelko mmelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mmelko mmelko merged commit 489b93d into KaotoIO:main Dec 2, 2022
@kahboom kahboom deleted the enhancements branch December 2, 2022 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmelko mmelko mmelko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kahboom @mmelko