Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tibdex/github-app-token from 1.3.0 to 1.6 #7

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5e6bd1a
Kargo Bid Adapter: Use currency from Bid Response
wwongkargo Mar 1, 2022
797a0f7
Kargo Bid Adapter: Fix failed test
wwongkargo Mar 2, 2022
88d6cfd
Kargo Bid Adapter: adding media type to bid response, supporting vast…
andyrusiecki May 18, 2022
2d79302
Merge branch 'prebid:master' into master
jsadwith May 23, 2022
0a03e35
Kargo Bid Adapter: onTimeout Support (#6)
jsadwith May 23, 2022
2bdf502
Adding additional param
jsadwith May 24, 2022
b634652
Adding response time function
jsadwith May 24, 2022
5f6f448
Remove debug
jsadwith May 24, 2022
50e0224
Updating response time log to be set by bid response
jsadwith May 25, 2022
a5eda12
Adding screen width/height to request
jsadwith May 27, 2022
f066881
Test fix
jsadwith May 27, 2022
62b1c1e
Test fix
jsadwith May 27, 2022
478191f
Removing interpretResponse signaling
jsadwith Jun 1, 2022
d884b69
Simplifying send data function
jsadwith Jun 1, 2022
451080f
Merge branch 'prebid:master' into master
jsadwith Jun 1, 2022
c012a35
Kargo Analytics Adapter: Update with bid response time support
jsadwith Jun 1, 2022
514f8ce
Renaming event route for auction data
jsadwith Jun 15, 2022
8639ae7
Reset bid response data sent bool
jsadwith Jun 27, 2022
47646ea
Using array to store logged auctions
jsadwith Jun 27, 2022
5ebbffb
Update to use timeToResponse
jsadwith Jul 6, 2022
2dac35a
Test fix
jsadwith Jul 6, 2022
6c06333
Merge branch 'prebid:master' into master
jsadwith Jul 21, 2022
fad3a88
Merge branch 'prebid:master' into master
jsadwith Aug 11, 2022
2c796ff
Kargo: Pull page URL from refererInfo
jsadwith Aug 11, 2022
d872284
Test fix: Page URL
jsadwith Aug 11, 2022
5099c91
Removing extra bracket
jsadwith Aug 11, 2022
84d4e11
Bump tibdex/github-app-token from 1.3.0 to 1.6
dependabot[bot] Aug 22, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/issue_tracker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:
- name: Generate token
id: generate_token
uses: tibdex/github-app-token@36464acb844fc53b9b8b2401da68844f6b05ebb0
uses: tibdex/github-app-token@f717b5ecd4534d3c4df4ce9b5c1c2214f0f7cd06
with:
app_id: ${{ secrets.ISSUE_APP_ID }}
private_key: ${{ secrets.ISSUE_APP_PEM }}
Expand Down
9 changes: 4 additions & 5 deletions modules/kargoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const spec = {
height: window.screen.height
},
prebidRawBidRequests: validBidRequests
}, spec._getAllMetadata(tdid, bidderRequest.uspConsent, bidderRequest.gdprConsent));
}, spec._getAllMetadata(bidderRequest, tdid));
const encodedParams = encodeURIComponent(JSON.stringify(transformedParams));
return Object.assign({}, bidderRequest, {
method: 'GET',
Expand Down Expand Up @@ -215,11 +215,10 @@ export const spec = {
return crb.clientId;
},

_getAllMetadata(tdid, usp, gdpr) {
_getAllMetadata(bidderRequest, tdid) {
return {
userIDs: spec._getUserIds(tdid, usp, gdpr),
// TODO: this should probably look at refererInfo
pageURL: window.location.href,
userIDs: spec._getUserIds(tdid, bidderRequest.uspConsent, bidderRequest.gdprConsent),
pageURL: bidderRequest.refererInfo && bidderRequest.refererInfo.page,
rawCRB: storage.getCookie('krg_crb'),
rawCRBLocalStorage: spec._getLocalStorageSafely('krg_crb')
};
Expand Down
13 changes: 11 additions & 2 deletions test/spec/modules/kargoBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ describe('kargo adapter tests', function () {
optOut: false,
usp: '1---'
},
pageURL: window.location.href,
pageURL: 'https://www.prebid.org',
prebidRawBidRequests: [
{
bidId: 1,
Expand Down Expand Up @@ -327,10 +327,19 @@ describe('kargo adapter tests', function () {
if (excludeTdid) {
delete clonedBids[0].userId.tdid;
}
var payload = { timeout: 200, uspConsent: '1---', foo: 'bar' };
var payload = {
timeout: 200,
uspConsent: '1---',
foo: 'bar',
refererInfo: {
page: 'https://www.prebid.org',
},
};

if (gdpr) {
payload['gdprConsent'] = gdpr
}

var request = spec.buildRequests(clonedBids, payload);
expected.sessionId = getSessionId();
sessionIds.push(expected.sessionId);
Expand Down