Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

fix #262 #264

Merged
merged 1 commit into from
Jul 7, 2020
Merged

fix #262 #264

merged 1 commit into from
Jul 7, 2020

Conversation

binarynoise
Copy link
Contributor

📌 References

🎩 What is the goal?

Fix permission listener not called after starting new dialog

📝 How is it being implemented?

see #262 (comment)

🤖 How can it be tested?

  • Use case 1: Start new Dialog from within the permission listener
  • Use case 2: Start new Dialog when Animations triggered by previous permission listener are still going on (and thus the main thread is busy)

@pedrovgs pedrovgs self-requested a review July 7, 2020 06:25
@pedrovgs
Copy link
Contributor

pedrovgs commented Jul 7, 2020

Hi @binarynoise this fix is just perfect. I'd love to see some automated tests but I guess it is ok for now in order to fix this bug. I'm merging it and releasing a new version so the user who reported the original bug can check if it is working for them. Thank you so much for your contribution.

@pedrovgs pedrovgs merged commit c0af2bd into Karumi:master Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants