-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netkit Lab Generator v1.4.0 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [electron](https://github.com/electron/electron) from 24.2.0 to 24.8.5. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v24.2.0...v24.8.5) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* conversion to frr * Fixed bug for frr conversion Fixed bug when a router was running both ospf and rip, the former would overwrite the latter. Now every frr.conf line is appended one after another. * Fix makeBgpConf appending "router bgp" to frr.conf instead of reassigning the string * test * updated electron (?) * Added routing software option * electron update (don't know) * Update generateZip function to include daemonOption parameter * changed place drop down menu for routing software * removed unused variable * added routing software choice for single router * custom commands for frr.conf can now be put in the appropriate text box * corretto mispelling * Solved bug where in model.js where frr.free was not initialised and didn't allow the lab to generate correctly * Capitalised Frr * selected frr as standard choice * specified base image for terminal, ws, ns * Corrected error where frr would be thrown out of bgp "mode" when adding bgp debug commands not allowing custom frr.conf commands to fall in the bgp section * Update package-lock.json * Update package.json * Update package.json * Delete package.json * Create package.json * removed daemonOption param * removed code block that would have never run * Updated DNS to new name daemon. Fixed bug in DNS configuration (legacy bug?) * Update index.html * introduced text boxes to allow custom commands in frr.conf * added paragraph level break in index.html between text boxes
tcaiazzi
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New release of the Netkit Lab Generator.
Include: