Fix typo bug with vreinterpretq + CI improvements #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type order is swapped; we got it right most places but missed it here. Not sure why CI didn't catch this error?
|
@Rooholla-KhorramBakht, are you able to confirm that this PR fixes #20 for you? The CI failure on Ubuntu is unrelated. |
Eventually, we're going to want to add Python tests, so we might as well set up for it. Also, nanobind only requires `typing_extensions` on Python <3.11, so we can remove that install (which errors on Ubuntu 24 with Python 3.12).
|
Hi, thanks for the quick addressing of the problem! I'll verify as soon as I'm back in the lab. |
zkingston
approved these changes
Jul 18, 2024
|
After fixing two extra type issues (pull request #22), the package compiled and installed on my Orin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20. We had a typo in two uses of vreinterpretq which tried to cast the wrong direction. Not
sure why we didn't see this on other ARM platforms - maybe just more lenient compilers, since the
reinterpret should be a NOP.
Also updates/cleans up the build CI, since I was in there anyway checking if we had an ARM runner.