Clarify Key formats #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like that a lot! Much cleaner than my initial idea. |
26 tasks
JadedBlueEyes
referenced
this pull request
in JadedBlueEyes/jsonwebtoken
Apr 13, 2023
Clarify Key formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a rethink of my old PR #74 that I think improves the API to be more clear for users by forcing them to specify the key format (this is fudged a bit for HMAC) that they are using. This makes the API more explicit and is a breaking change, but it's pretty trivial to update calls so I think it's an overall win, but I'm open to suggestions for making it more ergnomic.