Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA JSONs for Keychron q8 #4

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Add VIA JSONs for Keychron q8 #4

merged 1 commit into from
Dec 5, 2022

Conversation

KeychronMacro
Copy link
Member

@KeychronMacro KeychronMacro commented Dec 5, 2022 •
edited
Loading

Add VIA support for Keychron Q8
Thank you

Description

  • Add VIA JSONs for Keychron Q8

  1. Add ANSI and ISO versions, including encoder variants

  2. Add encoder ID (e0) as the center label for encoder keys to support encoder mapping

  • Correct cycle effect names to proper spelling for Q boards

QMK Pull Request

qmk/qmk_firmware#19126

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@KeychronMacro KeychronMacro merged commit 0d62890 into Keychron:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KeychronMacro @galican