Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI/#3] 홈(infomain) / 뷰페이저 뷰 구현 #15

Merged
merged 14 commits into from
Jan 2, 2023
Merged

[UI/#3] 홈(infomain) / 뷰페이저 뷰 구현 #15

merged 14 commits into from
Jan 2, 2023

Conversation

etama123
Copy link
Member

@etama123 etama123 commented Jan 1, 2023 •
edited
Loading

관련 이슈

작업 내역

  • 홈 viewPager구현
  • 홈 xml 작성

PR 포인트

일단 뷰페이저 연결했구 이제 adapter로 리사이클러뷰 붙일 예정입니다!~

실행화면

Android.Emulator.-.Pixel_3_XL_API_29_5554.2023-01-01.16-35-16.mp4

@etama123 etama123 added UI 💄 UI 작업 동주 🦦 동주's task Pull Request 🤗 pull reqeust 날리기 labels Jan 1, 2023
@etama123 etama123 added this to the 랩실 구현 연습 ✏️ milestone Jan 1, 2023
@etama123 etama123 requested a review from a team January 1, 2023 08:23
b1urrrr
b1urrrr reviewed Jan 1, 2023
View reviewed changes
Copy link
Member

@b1urrrr b1urrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 너무 고생많았어😭
뷰페이저까지 잘 구현했네 이따가 다시 코드 자세히 보면서 리뷰 할게요!!

0zlrlo
0zlrlo approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@0zlrlo 0zlrlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당!!

app/src/main/res/layout/fragment_home.xml Show resolved Hide resolved
app/src/main/res/layout/fragment_home.xml Outdated Show resolved Hide resolved
app/src/main/java/com/lab/keyneez/presentation/main/home/HomeFragment.kt Show resolved Hide resolved
@etama123 etama123 self-assigned this Jan 1, 2023
@b1urrrr b1urrrr changed the title [UI/#3] 홈(infomain) 뷰페이저 뷰 구현 [UI/#3] 홈(infomain) / 뷰페이저 뷰 구현 Jan 1, 2023
b1urrrr
b1urrrr requested changes Jan 1, 2023
View reviewed changes
Copy link
Member

@b1urrrr b1urrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뷰페이저 구현하시느라 고생하셨습니다🥲
여기에 리사이클러뷰만 구현하면 HomeFragment는 완성되겠네요!!
화이팅이에요 🔥

app/build.gradle Outdated Show resolved Hide resolved
app/src/main/java/com/lab/keyneez/presentation/main/home/HomeFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/com/lab/keyneez/presentation/main/home/HomeFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/com/lab/keyneez/presentation/main/home/HomeFragment.kt Outdated Show resolved Hide resolved
app/src/main/res/drawable/logoa.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_home.xml Show resolved Hide resolved
app/src/main/res/layout/fragment_home.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/item_infomain.xml Outdated Show resolved Hide resolved
app/src/main/java/com/lab/keyneez/presentation/main/home/adapter/HomeVPFragmentAdapter.kt Outdated Show resolved Hide resolved
app/src/main/res/drawable/ic_search.xml Outdated Show resolved Hide resolved
@etama123
[RENAME/#3] fragment 이름 변경
7fe527b
@etama123
[FIX/#3] 코드리뷰 반영
08f5c43 
- string 값 추가
- fragment에서 getString() 으로 string값 불러오기
- ic, img 이름 컨벤션에 맞게 수정
@etama123
[CHORE/#3] build.gradle 값 수정
e646583
@etama123
[FIX/#3] rename 반영
8a36d2e
@etama123 etama123 requested a review from b1urrrr January 2, 2023 07:21
b1urrrr
b1urrrr approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@b1urrrr b1urrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@b1urrrr
Copy link
Member

b1urrrr commented Jan 2, 2023

지은이가 머지한 내용 풀 받고 푸시해서 머지해주세요!

@etama123 etama123 merged commit 804173e into develop Jan 2, 2023
@etama123 etama123 deleted the feature/#3-infomain-layout branch January 2, 2023 07:42
@b1urrrr b1urrrr mentioned this pull request Mar 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0zlrlo 0zlrlo 0zlrlo approved these changes

@b1urrrr b1urrrr b1urrrr approved these changes

Assignees

@etama123 etama123

Labels
Pull Request 🤗 pull reqeust 날리기 UI 💄 UI 작업 동주 🦦 동주's task
Projects
Keyneez Android Lab Project
Status: Done
Milestone
랩실 구현 연습 ✏️
Development

Successfully merging this pull request may close these issues.

[UI] 인포 메인 / 뷰 생성
3 participants
@etama123 @b1urrrr @0zlrlo