Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement feedback on copy for Bani Overlay URL #1908

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Implement feedback on copy for Bani Overlay URL #1908

merged 2 commits into from
Mar 20, 2024

Conversation

yadvirkaur
Copy link
Collaborator

#1193

Bani Overlay URL copy functionality:

  • When clicking on the copy icon for the Bani Overlay URL, it copies the URL to your clipboard and displays feedback.
  • Clicking on the URL selects URL text and copies it to your clipboard.

@yadvirkaur yadvirkaur changed the title Implement feedback on copy for Bani Overlay URL #1193 Implement feedback on copy for Bani Overlay URL Mar 18, 2024
@Gauravjeetsingh Gauravjeetsingh self-requested a review March 18, 2024 23:11
Gauravjeetsingh
Gauravjeetsingh requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@Gauravjeetsingh Gauravjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change, everything else looks good.

www/main/overlay/components/CopyToClipboard.jsx Outdated Show resolved Hide resolved
Gauravjeetsingh
Gauravjeetsingh approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@Gauravjeetsingh Gauravjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, merging this PR. Thank you @yadvirkaur

@inderpreetsingh inderpreetsingh merged commit c5f9fd1 into KhalisFoundation:dev Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravjeetsingh Gauravjeetsingh Gauravjeetsingh approved these changes

@inderpreetsingh inderpreetsingh inderpreetsingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yadvirkaur @inderpreetsingh @Gauravjeetsingh