Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix element type when reading OpPtrDiff #2683

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix element type when reading OpPtrDiff #2683

merged 1 commit into from
Aug 26, 2024

Conversation

svenvh
Copy link
Member

@svenvh svenvh commented Aug 22, 2024

The first argument to IRBuilder's CreatePtrDiff must be the element type, not the pointer type; otherwise the resulting difference will be scaled incorrectly.

@svenvh
Fix element type when reading OpPtrDiff
7f5f189 
The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.
vmaksimo
vmaksimo approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@vmaksimo vmaksimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@svenvh svenvh merged commit b5938f0 into KhronosGroup:main Aug 26, 2024
9 checks passed
@svenvh svenvh deleted the ptrdiff-fix branch August 26, 2024 08:47
svenvh added a commit to svenvh/SPIRV-LLVM-Translator that referenced this pull request Aug 26, 2024
@svenvh
[Backport to 19] Fix element type when reading OpPtrDiff (KhronosGrou…
278afac 
…p#2683)

The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
svenvh added a commit to svenvh/SPIRV-LLVM-Translator that referenced this pull request Aug 26, 2024
@svenvh
[Backport to 18] Fix element type when reading OpPtrDiff (KhronosGrou…
0a2407b 
…p#2683)

The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
svenvh added a commit to svenvh/SPIRV-LLVM-Translator that referenced this pull request Aug 26, 2024
@svenvh
[Backport to 17] Fix element type when reading OpPtrDiff (KhronosGrou…
79339a9 
…p#2683)

The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
svenvh added a commit that referenced this pull request Aug 26, 2024
@svenvh
[Backport to 19] Fix element type when reading OpPtrDiff (#2683) (#2684)
d65c25a 
The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
svenvh added a commit that referenced this pull request Aug 26, 2024
@svenvh
[Backport to 18] Fix element type when reading OpPtrDiff (#2683) (#2685)
242df2c 
The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
svenvh added a commit that referenced this pull request Aug 26, 2024
@svenvh
[Backport to 17] Fix element type when reading OpPtrDiff (#2683) (#2686)
3aa5bcd 
The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
svenvh added a commit to svenvh/SPIRV-LLVM-Translator that referenced this pull request Aug 26, 2024
@svenvh
[Backport to 16] Fix element type when reading OpPtrDiff (KhronosGrou…
9e2caff 
…p#2683)

The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
svenvh added a commit to svenvh/SPIRV-LLVM-Translator that referenced this pull request Aug 26, 2024
@svenvh
[Backport to 15] Fix element type when reading OpPtrDiff (KhronosGrou…
a2a06e9 
…p#2683)

The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
svenvh added a commit to svenvh/SPIRV-LLVM-Translator that referenced this pull request Aug 26, 2024
@svenvh
[Backport to 14] Fix element type when reading OpPtrDiff (KhronosGrou…
6c01910 
…p#2683)

The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
MrSidims pushed a commit that referenced this pull request Aug 27, 2024
@svenvh
[Backport to 14] Fix element type when reading OpPtrDiff (#2683) (#2690)
3cd22b5 
The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
MrSidims pushed a commit that referenced this pull request Aug 27, 2024
@svenvh
[Backport to 15] Fix element type when reading OpPtrDiff (#2683) (#2689)
1e170e2 
The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
MrSidims pushed a commit that referenced this pull request Aug 27, 2024
@svenvh
[Backport to 16] Fix element type when reading OpPtrDiff (#2683) (#2688)
1f9e0e3 
The first argument to IRBuilder's `CreatePtrDiff` must be the element
type, not the pointer type; otherwise the resulting difference will
be scaled incorrectly.

(cherry picked from commit b5938f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaksimo vmaksimo vmaksimo approved these changes

@MrSidims MrSidims Awaiting requested review from MrSidims

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenvh @vmaksimo