Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SPV_KHR_compute_shader_derivative #5817

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Add support for SPV_KHR_compute_shader_derivative #5817

merged 3 commits into from
Sep 25, 2024

Conversation

EpicJeanNoeMorissette
Copy link
Contributor

Replace support for SPV_NV_compute_shader_derivatives with the new KHR (many lists had the vendor extension twice, replace one with the new KHR).

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

alan-baker
alan-baker requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change to the allow lists in optimization passes.

source/opt/aggressive_dead_code_elim_pass.cpp Show resolved Hide resolved
@alan-baker
Copy link
Contributor

It looks like you missed a few test updates.

[  PASSED  ] 6974 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] ValidateDerivatives.OpDPdxWrongExecutionModel
[  FAILED  ] ValidateDerivatives.NoExecutionModeGLCompute

Try ctest -j<N> after fixing them to confirm those are the only failures.

@s-perron s-perron enabled auto-merge (squash) September 24, 2024 23:24
@alan-baker
Copy link
Contributor

Please fix the formatting.

@alan-baker
Copy link
Contributor

Please fix the formatting.

I fixed this.

@s-perron s-perron merged commit 44936c4 into KhronosGroup:main Sep 25, 2024
24 checks passed
Keenuts pushed a commit to Keenuts/SPIRV-Tools that referenced this pull request Nov 12, 2024
@EpicJeanNoeMorissette @MagicPoncho @Keenuts
Add support for SPV_KHR_compute_shader_derivative (KhronosGroup#5817)
15c6bc0 
* Add support for SPV_KHR_compute_shader_derivative

* Update tests for SPV_KHR_compute_shader_derivatives

---------

Co-authored-by: MagicPoncho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-baker alan-baker alan-baker approved these changes

@dneto0 dneto0 dneto0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@EpicJeanNoeMorissette @CLAassistant @alan-baker @dneto0 @kokoro-team @s-perron @MagicPoncho