opt: Update copy prop arrays to handle InterpolateAt* instructions #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-perron
reviewed
Oct 1, 2024
cassiebeckley
force-pushed
the
evaluate-at-copy-prop
branch
from
adb54f4
to
4b01bd4
Compare
cassiebeckley
force-pushed
the
evaluate-at-copy-prop
branch
from
72f4038
to
823e69b
Compare
cassiebeckley
changed the title
|
@s-perron the discussed changes have been finished |
cassiebeckley
changed the title
s-perron
approved these changes
Oct 2, 2024
cassiebeckley
added a commit
that referenced
this pull request
Oct 16, 2024
#5827 is broken for situations where a loaded value is stored to a pointer resulting from an OpAccessChain. Traverse access chains to find the original OpVariable to add to the worklist.
Keenuts
pushed a commit
to Keenuts/SPIRV-Tools
that referenced
this pull request
Nov 12, 2024
…hronosGroup#5827) Adds support for `InterpolateAtCentroid`, `InterpolateAtSample`, and `InterpolateAtOffset` to the copy propagate arrays pass, as well as propagating pointers with the `Input` storage class. Also handles situations where variables should be propagated in an order different than the order that they are declared in the source.
Keenuts
pushed a commit
to Keenuts/SPIRV-Tools
that referenced
this pull request
Nov 12, 2024
…p#5853) KhronosGroup#5827 is broken for situations where a loaded value is stored to a pointer resulting from an OpAccessChain. Traverse access chains to find the original OpVariable to add to the worklist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
InterpolateAtCentroid,InterpolateAtSample, andInterpolateAtOffsetto the copy propagate arrays pass, as well as propagating pointers with theInputstorage class. Also handles situations where variables should be propagated in an order different than the order that they are declared in the source.