Enable half/double cmake options #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable cmake options filtering out half/double tests at compile time: - SYCL_CTS_ENABLE_HALF_TESTS - SYCL_CTS_ENABLE_DOUBLE_TESTS Default option values are switched to ON, because: - neither SYCL_CTS_ENABLE_DOUBLE_TESTS nor SYCL_CTS_ENABLE_HALF_TESTS affect any of the current tests in the CTS: tests currently behave like if these options are ON by default - half types should be available at the compile time according to the SYCL 1.2.1, 5.1 and SYCL 2020, D.6.1 - in case there is no fp16/fp64 extension available for device, a feature_not_supported exception should be thrown at the runtime - double types should be available at the compile time according to the SYCL 1.2.1, 4.10.1 and 6.5 - according to the SYCL 2020, 6.5 an implementation may not raise an error in case application did not specifically ask to submit the kernel to the specific device or to compile the kernel for it Options are enabled for new fp16/fp64 tests naming convention only; any elder tests can be modified to use macro defines if required
ProGTX
approved these changes
Jan 20, 2021
bader
approved these changes
Jan 20, 2021
keryell
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable cmake options filtering out half/double tests at compile time:
Default option values are switched to ON, because:
affect any of the current tests in the CTS:
tests currently behave like if these options are ON by default
SYCL 1.2.1, 5.1 and SYCL 2020, D.6.1
feature_not_supported exception should be thrown at the runtime
the SYCL 1.2.1, 4.10.1 and 6.5
error in case application did not specifically ask to submit the
kernel to the specific device or to compile the kernel for it
Options are enabled for new fp16/fp64 tests naming convention only;
any elder tests can be modified to use macro defines if required