Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change flip texture coordinates with flip texture #562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

owilliamailliwo
Copy link
Contributor

Better not to flip the texture coordinates. If uv* represents something else other than coordinates, we cannot simply perform 1 - uv*.y on it.

… the texture coordinates. If uv* represents something else other than coordinates, we cannot simply perform 1 - uv*.y on it.
Skylion007 referenced this pull request in prefrontalcortex/UnityGLTF Sep 24, 2020
@hybridherbst
Copy link
Collaborator

@pfcDorn @marwie we may want to look at this again, we've discussed a couple times if this would make sense. For roundtrips and trying to keep them as lossless as possible I still prefer the UV flip, but not sure in the general case. I don't think it's good to introduce a special option either though (and keep both code paths – I think we want one).

By now it encompasses a lot more than what's in this PR; e.g. UV animation and so on need to be handled as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants