Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate image barrier access layout combinations #3970

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Validate image barrier access layout combinations #3970

merged 2 commits into from
Oct 17, 2022

Conversation

ziga-lunarg
Copy link
Contributor

Closes #2918

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 14581.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 6796 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 14594.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 6797 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 6797 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 26301.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 8530 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 8530 failed.

ncesario-lunarg
ncesario-lunarg approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@ncesario-lunarg ncesario-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits, but LGTM!

layers/best_practices_utils.cpp Outdated Show resolved Hide resolved
layers/best_practices_utils.cpp Show resolved Hide resolved
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 30103.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 8589 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 8589 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 14899.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 9003 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 9003 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 15022.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 9013 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 9013 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 15152.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 9020 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 9020 passed.

@spencer-lunarg spencer-lunarg merged commit d866ffd into KhronosGroup:master Oct 17, 2022
@Tobski Tobski mentioned this pull request Nov 2, 2022
Closed
@Eearslya Eearslya mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-lunarg spencer-lunarg spencer-lunarg approved these changes

@ncesario-lunarg ncesario-lunarg ncesario-lunarg approved these changes

@TonyBarbour TonyBarbour Awaiting requested review from TonyBarbour

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Best Practices] Validate invalid access/layout combinations for VkImageMemoryBarrier{2KHR}
4 participants
@ziga-lunarg @ci-tester-lunarg @ncesario-lunarg @spencer-lunarg