Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layers: Check vkGetDescriptorSetLayoutSupport #7609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

layers: Check vkGetDescriptorSetLayoutSupport #7609

wants to merge 1 commit into from

Conversation

spencer-lunarg
Copy link
Contributor

From https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/6269

Call vkGetDescriptorSetLayoutSupport for apps

this catches Mutable Descriptor tests failing on MESA because they don't support VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER (but NVIDIA does)

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner February 29, 2024 06:46
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 141862.

spencer-lunarg
spencer-lunarg commented Feb 29, 2024
View reviewed changes
tests/unit/descriptors.cpp
@@ -4141,286 +4141,309 @@ TEST_F(NegativeDescriptors, BindingDescriptorSetFromHostOnlyPool) {
m_commandBuffer->end();
}

TEST_F(NegativeDescriptors, CopyMutableDescriptors) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test was already basically 3 tests, so just broke it up to improve coverage on MESA (2 of the 3 work, and didn't want to skip the other 2)

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 15969 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 15969 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 142561.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 15981 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 15981 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 144140.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16005 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16005 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 145234.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16026 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16026 failed.

arno-lunarg
arno-lunarg approved these changes Mar 6, 2024
View reviewed changes
layers/core_checks/cc_descriptor.cpp
std::stringstream error_str;
error_str << "was passed into vkGetDescriptorSetLayoutSupport and returned not supported";
if (using_mutable_type) {
error_str << " (verify mutable type are supported, not every driver supports mutable types such as "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
error_str << " (verify mutable type are supported, not every driver supports mutable types such as "
error_str << " (verify mutable types are supported, not every driver supports mutable types such as "

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 149388.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16103 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16103 failed.

@spencer-lunarg spencer-lunarg mentioned this pull request Mar 21, 2024
Closed
@spencer-lunarg spencer-lunarg mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arno-lunarg arno-lunarg arno-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencer-lunarg @ci-tester-lunarg @arno-lunarg