[WIP] Export: use nodes for Alpha clipping #2152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, |
|
The failures are just roundtrip tests, which is expected. They will pass when both import and export PRs are merged. I'm not planning on putting everything in one mega-PR. |
|
Closing, as we created a single PR with all alpha clipping stuff: #2155 |
| if info['alphaColorAttrib'] is None: | ||
| attr = get_color_attrib(alpha_nav) | ||
| if attr is not None: | ||
| info['alphaColorAttr'] = attr |
There was a problem hiding this comment.
Just found a typo here, should be 'alphaColorAtttrib'
|
|
||
| attr = detect_multiply_by_color_attrib(alpha_nav) | ||
| if attr is not None: | ||
| info['alphaColorAttr'] = attr |
There was a problem hiding this comment.
Just found a typo here, should be 'alphaColorAtttrib'
| prev.node.type == 'MIX' and | ||
| prev.node.data_type == 'RGBA' and | ||
| prev.node.blend_type == 'MULTIPLY' and | ||
| prev.get_constant('Fac') == 1 |
There was a problem hiding this comment.
Typo here: Should be 'Factor'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does #2111 for the exporter.
Uses nodes to determine the alpha mode and cutoff.
To export OPAQUE materials, just set Alpha to 1.
To export MASK materials, use either
round(alpha)or1-(alpha < cutoff).(Constant 0 Alpha also exports as MASK.)
Other setups use BLEND.
Implemented by adding a
gather_alpha_infofunction that parses all the info from nodes hanging off the Alpha socket except the texture. There are several utility functions to support it.This should also solve #2110 for Alpha color attributes (not RGB colors).
Tested lightly for both Principled and unlit with stuff like