Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and simplify formula for attenuation #2414

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

emackey
Copy link
Member

@emackey emackey commented Jun 17, 2024

Fixes #2390

Based on comments in #2390 (comment)

Related sample viewer PR: KhronosGroup/glTF-Sample-Viewer#550

@emackey
Copy link
Member Author

emackey commented Jun 17, 2024

/cc @bsdorra

Copy link
Contributor

@abwood abwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the math simplification outlined by Alexey in the linked issue. Thanks @emackey

@abwood abwood merged commit cc633b8 into main Jun 19, 2024
3 checks passed
@abwood abwood deleted the attenuation-zero-spec branch June 19, 2024 18:51
abbaswasim pushed a commit to abbaswasim/glTF that referenced this pull request Sep 7, 2024
kwokcb added a commit that referenced this pull request Sep 17, 2024
* KHR_materials_ior: Minor typo: plural instead of singular (#2413)

* Update anisotropy extension spec (#2409)

* Clarify and simplify formula for attenuation. (#2414)

* Add TRACE prefix (#2417)

* Update clearcoat extension spec (#2415)

* Update README. (#2427)

* Add KHR_node_hoverability (#2428)

* Add KHR_node_hoverability
* Resort extension list

* EXT_mesh_gpu_instancing: Suggest extensionRequired usage (#2405)

* Add button/link to glTF Discord (#2429)

As there is a lot more traffic to the Khronos glTF Discord than there is to Slack, a button pointing users to Discord will be helpful.

---------

Co-authored-by: Andreas Atteneder <[email protected]>
Co-authored-by: Alexey Knyazev <[email protected]>
Co-authored-by: Ed Mackey <[email protected]>
Co-authored-by: Marco Hutter <[email protected]>
Co-authored-by: Khronos Group Web Services <[email protected]>
Co-authored-by: Arseny Kapoulkine <[email protected]>
Co-authored-by: James Riordon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined behaviour in KHR_materials_volume
2 participants