Use line and column from node on DebugLexicalBlock. #3737
Conversation
|
You should add a test that exercises this functionality. |
sajjadmirzanv
force-pushed
the
lexical-line
branch
from
992799b
to
cee7e98
Compare
I discovered that there was a bug in the test runner, which is why the existing nonsemantic tests were not already triggering this code. Running glslang -gVS on those files emits DebugLexicalLine, but it was missing when run through glslangtests. In TestFixture.h, the code was only generating debug info for the 2nd stage of compilation, from IR -> SPIRV. I enabled the flag so it also emits debug info during Source Language -> IR compilation. The result is that we get EOpScope nodes in the tree, so the GlslangToSpv converter can emit DebugLexicalBlock instructions. I had to make a few other small changes to some tests as well. |
sajjadmirzanv
force-pushed
the
lexical-line
branch
from
b7d1d87
to
ec1f2d6
Compare
| if (enableDebug) { | ||
| shader.setDebugInfo(true); | ||
| } | ||
| if (enableNonSemanticShaderDebugInfo) { |
There was a problem hiding this comment.
I like this forcing of correct usage. We might want to force enableNonSemanticShaderDebugInfo to set enableDebug at a lower level, but I will investigate that in a separate PR.
Old implementation had every DebugLexicalBlock hardcoded to (0, 0), but IR nodes know their source location so we may as well attach it to the DebugLexicalBlock.