Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error with xcode 9 #34

Closed
wants to merge 8 commits into from
Closed

Fix build error with xcode 9 #34

wants to merge 8 commits into from

Conversation

yongpingchen
Copy link
Contributor

@yongpingchen yongpingchen commented Feb 7, 2018 •
edited
Loading

  • fixed xib file to build for iOS 8.0 or later
  • fixed appledoc build failure.
    • remove appledoc binary
    • use latest appledoc
    • fixed document warning caused appledoc build failure.
  • GHUnit was deprecated, so skip the test in CI.

@yongpingchen yongpingchen assigned dairyo and unassigned dairyo Feb 7, 2018
@yongpingchen yongpingchen added this to the v1.2.1 milestone Feb 7, 2018
dairyo
dairyo reviewed Feb 7, 2018
View reviewed changes
Copy link

@dairyo dairyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked ios-control/ios-sim#201 but I could not find why ios-sim command does not exits.

Could you explain detail of it?

circle.yml

dependencies:
pre:
- brew install ios-sim
- ios-sim showdevicetypes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need ios-sim showdeivetypes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to confirm the list of supported device in circle ci. Since the list is different with local ones.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
Can you remove this?

@yongpingchen
Copy link
Contributor Author

yongpingchen commented Feb 7, 2018 •
edited
Loading

@shinsuke-nara

I have checked ios-control/ios-sim#201 but I could not find why ios-sim command does not exits.
Could you explain detail of it?

exist is exit, right?
I also don't know why the command not exit. But it did happen in my machine and circle CI.
I guess it caused by GHUnit tests.
And since GHUnit tests were deprecated. We don't want to spend more time on them.

@dairyo
Copy link

dairyo commented Feb 7, 2018 •
edited
Loading

@yongpingchen

photocolle-iOSSDK/photocolle-sdk/Makefile

Line 34 in f81a981

ios-sim launch $(APPOUTDIR)/Applications/GHUnitTests.app --devicetypeid "com.apple.CoreSimulator.SimDeviceType.iPhone-6, 9.2" --exit

In develop branch, we use --exit option for ios-sim. Could you try this?

@yongpingchen
Copy link
Contributor Author

develop branch already fixed it. We decide to close it

@yongpingchen yongpingchen deleted the fix_build_error_xcode_9 branch February 7, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dairyo dairyo dairyo left review comments

@satoshikumano satoshikumano Awaiting requested review from satoshikumano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
hotfix-v1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@yongpingchen @dairyo