Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V097S6 - Respawn refactor #499

Merged
merged 24 commits into from
Sep 23, 2018
Merged

V097S6 - Respawn refactor #499

merged 24 commits into from
Sep 23, 2018

Conversation

veteran29
Copy link
Member

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues -

Description:

Custom respawn system was refactored into separate module with usage of CfgRespawnTemplates.

Content:

  • Removed respawn marker
  • Custom respawn system
  • Redeploy event
  • Streamlined and more robust code
  • Easy way of adding mobile respawns by adding KPLIB_respawn = true variable on objects
  • On water mobile respawn support
  • core functions were moved into separate .hpp file for readability

Tested on:

  • Local MP Vanilla
  • Local MP ACE
  • Dedicated MP Vanilla
  • Dedicated MP ACE

@veteran29
Move respawn to separate module
8a41f24
@veteran29
Allow for boats as mobile respawn vehicles
d8e1ea4
@veteran29
Support for multiple mobile respawn objects
f497460
@veteran29
Fix build_markArea radius argument
9a60828
@veteran29
Start respawn refactor, move respawn into CfgRespawnTemplates
29d4bff
@veteran29
Move respawn action handling to event
cbc84ca
@veteran29
Fix core_getMobSpawns
b64c91b 
The the check for boat/water was broken
@veteran29
Implement respawning on selected position
39d1d7f 
Map animation and camera are still missing
@veteran29
Remove accidental "allowFunctionsRecompile"
b9221c4
@veteran29
Periodic respawns fetching, update map pos on respawn selection
d2dbbd2
@veteran29
Add common_getPos, split core/functions.hpp into multiple files
e5944ae
@veteran29
Rename respawn_displayUpdateMap
7909f59
@veteran29
Rename respawn_displayUpdateList
cef8502
@veteran29
Fix common_getPos crashing the game
0486477
@veteran29
Fix loudout handling, rename functions and variables, remove logging
6ae2b4a
@veteran29
Reveal player to nearby units on respawn
6583a28
@veteran29
Fix onKilled waitUntil
9bf592f
@veteran29
Remove respawn marker
9b258c2
@veteran29
Move CfgRespawnTemplates under respawn settings
4a9693d
@veteran29
Fix respawn sometimes not working properly when BIS revive was used.
954d083
@veteran29
Decrease reveal value and range
632561a
@veteran29
Add camera view for selected respawn position
5242114
@veteran29
Emit event on player redeploy
f5884fb
@veteran29
Search for empty area on redeploy
a1b5730
Wyqer
Wyqer approved these changes Sep 23, 2018
View reviewed changes
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and it's a real enhancement to refactor the old redeploy function in the way we currently implement the dialogs etc.
Good work, I like it. 👍

@veteran29 veteran29 merged commit 039cd7f into v0.97S6 Sep 23, 2018
@veteran29 veteran29 deleted the v097-respawn-refactor branch September 23, 2018 20:21
@veteran29 veteran29 added the done label Sep 24, 2018
@Wyqer Wyqer added this to the Sprint 6 milestone Oct 8, 2018
@Wyqer Wyqer mentioned this pull request Oct 8, 2018
Closed
@Wyqer Wyqer mentioned this pull request Nov 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyqer Wyqer Wyqer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 6
Development

Successfully merging this pull request may close these issues.
2 participants
@veteran29 @Wyqer