-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function headers overhaul #525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already discussed in Discord it seems all fine.
And as you've tested everything there shouldn't happen errors due to param default value changes.
But it's of course something we need to rethink in some cases if switching from something like nil
to the zeroPos
for a position argument could be something which makes it harder to debug as it won't throw an error and just dump/create something at the corner of the map under the water surface.
Overall it looks good to me and the mentioned default value changes would be something we can easily adjust when we encounter some unwanted behaviour.
Description:
All function headers are overhauled and all
params
are defined as precise as possible.Now the function tooltips should be properly displayed and function calls without arguments or wrong arguments will be overwritten by the
defaultValue
anddataType
definitions.Content:
Successfully tested on:
Compatibility checked with: