Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly/Enemy universal army presets #535

Merged
merged 9 commits into from
Nov 25, 2018
Merged

Friendly/Enemy universal army presets #535

merged 9 commits into from
Nov 25, 2018

Conversation

Wyqer
Copy link
Member

@Wyqer Wyqer commented Nov 24, 2018

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues #522

Description:

This contains the first draft for the universal presets, which are automatically create friendly/enemy variables and presets depending on one passed argument upon compiling the preset.
All content can be viewed in the readme.md Cheat Sheet in the new armies folder.

These changes needs many adjustments to already "finished" code, which needs to be adressed in the upcoming sprints. But the benefit of a universal preset is worth the work.

So for now it's provided additionally to the "old unit presets" and not used until we made all necessary changes at every place in the code.

Content:

  • Small changes to the globals of the preset CBA settings
  • NATO Preset
  • CSAT Preset
  • Custom West Preset file
  • Custom East Preset file
  • Preset Cheat Sheet

Successfully tested on:

  • Local MP Vanilla
  • Dedicated MP Vanilla

Compatibility checked with:

  • None

@Wyqer Wyqer added this to the Sprint 8 milestone Nov 24, 2018
veteran29
veteran29 previously approved these changes Nov 24, 2018
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, personally I think we could use underscores in macro names for better readability.

Eg. KPLIB_PRST_AR_CREATE

Dubjunk
Dubjunk previously approved these changes Nov 24, 2018
@Wyqer Wyqer dismissed stale reviews from Dubjunk and veteran29 via a02eac8 November 25, 2018 07:16
@Wyqer Wyqer merged commit 5ff20cb into v0.97S8 Nov 25, 2018
@Wyqer Wyqer deleted the v0.97S8-522 branch November 25, 2018 07:17
@Wyqer Wyqer added done and removed review/QA labels Nov 25, 2018
@Wyqer Wyqer mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants