Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small S8 tweaks and adjustments #537

Merged
merged 14 commits into from
Nov 27, 2018
Merged

Small S8 tweaks and adjustments #537

merged 14 commits into from
Nov 27, 2018

Conversation

Wyqer
Copy link
Member

@Wyqer Wyqer commented Nov 27, 2018

Q A
Bug fix? partially
New feature? yes
Needs wipe? no
Fixed issues #520

Description:

Just some small tweaks and adjustments for the S7 and S8 content until now.
The vehicle spawn issue (they sometimes fly, explode and do other fancy stuff in areas with many buildings) from #520 is still open and will be adressed in S9 or at least when the garrison module gets the next iteration.

Content:

  • Intro is completely removed for now. If we implement one in the future, we should write it completely from scratch
  • Moved the actions for opening the ADM and PLM dialog from the onPlayerRespawn to the modules postinits
  • Moved the stamina disable command from onPlayerRespawn to the respawn module
  • Removed onPlayerRespawn
  • Moved the wipe save data function back to the init module
  • Time Multiplier setting added to general settings
  • Fixed smaller things in arsenal and build module
  • Updates workspace vscode settings to ignore the core scripts (false undefined variable warning)
  • Added functionality to change preset during the game without needed server restart with reinitializing sector garrisons

Successfully tested on:

  • Local MP Vanilla
  • Dedicated MP Vanilla

Compatibility checked with:

  • NONE

@Wyqer Wyqer added this to the Sprint 8 milestone Nov 27, 2018
];

// Only execute on server, with valid parameter and not in mission init
if (!(time > 0) || !isServer || (_preset isEqualTo "")) exitWith {};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the handler is only added in a isServer category, I just thought it should be also a failsafe for manual local/global execution via debug console by server admins.

@Wyqer Wyqer merged commit 984d8c5 into v0.97S8 Nov 27, 2018
@Wyqer Wyqer deleted the v0.97S8-520 branch November 27, 2018 19:28
@Wyqer Wyqer added done and removed review/QA labels Nov 27, 2018
This was referenced Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants