-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build module - single item build, existing items movement #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veteran29
changed the title
V0.97 s8 523
Build module - single item build, existing items movement
Nov 29, 2018
Dubjunk
previously approved these changes
Nov 29, 2018
Wyqer
requested changes
Nov 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks in general good to me, but haven't had a look at it in the game itself. I'm confident it'll be nice from the look&feel, too.
Overall I recognized that there could be slightly more commenting at some code areas.
But well, it was very late ^^
Missionframework/modules/02_core/fnc/fn_core_getNearestMarker.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/02_core/fnc/fn_core_getNearestMarker.sqf
Outdated
Show resolved
Hide resolved
Wyqer
approved these changes
Nov 29, 2018
Dubjunk
approved these changes
Nov 29, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Further development of build module.
Content:
KPLIB_build_item_built_local
event,KPLIB_build_item_built
is global nowAdditional content
core_getNearestSector
refactored intocore_getNearestMarker
core_buildFob
into a "system" function used only for fob marker creation handlingcore_canBuildFob
Successfully tested on:
Compatibility checked with: