Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission system Part 1 #560

Merged
merged 79 commits into from
Dec 30, 2018
Merged

Permission system Part 1 #560

merged 79 commits into from
Dec 30, 2018

Conversation

Dubjunk
Copy link
Contributor

@Dubjunk Dubjunk commented Dec 23, 2018 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues #541

Description:

The permission module provides various functions and features to provide a functional and dynamic permission system.
The player can now fully control each permission via dialog and add/remove permissions in the postInit of each module.
Details will be provided later in the Liberation Wiki.

Content:

  • Create permissionmodule
  • Provide a permission dialog for the admin
  • Setup general functions
    • Check specific permission
    • Set permissions
  • Implement it to the various modules

Successfully tested on:

  • Local MP Vanilla
  • Dedicated MP Vanilla

Compatibility checked with:

  • NONE

Dubjunk and others added 30 commits December 7, 2018 11:28
@Dubjunk
added basic permission module structure
bb09422
@Dubjunk
added post and preInit
3c7f682
@Dubjunk
changed dialog id
9c2569b
@Dubjunk
added some basic functions
f64265b
@Dubjunk
save/load function WiP
6190c8f
@Dubjunk
renamed the register function
1ae42fa
@Dubjunk
added another function for the permission check
01abfcd
@Dubjunk
replaced custom namespace with missionNamespace
89266da
@Dubjunk
added some test functionalities
cb11428
@Dubjunk
missing brackets
d70a230
@Dubjunk
changed variable name
1933b63
@Dubjunk
added permission check
4e6572a
@Dubjunk
Added example permission array
d6114cd
@Dubjunk
changed arsenal dialog ID
ec6ded4
@Dubjunk
added player action
17b3259
@Dubjunk
openDIalog function
ceaf80a
@Dubjunk
sorted the permission types
2777284
@Dubjunk
Added some dialog controls
07f58c1
@Dubjunk
control creation position data WiP
d0951fd
@Wyqer
include classes in KPLIB_ui, not from defines
718577a 
This ensures that the defines for UI creation can be used for dynamic dialogs.
Otherwise the class definition would be running twice.
@Dubjunk
added stringtable entry for permission handlers
d5b949d
@Dubjunk
some more dialog work
5deca19
@Dubjunk
typo
9bcc529
@Dubjunk
added dynamic permission dialog creation
f2596e5
@Dubjunk
added more permission types
82bbc0c
@Dubjunk
typo
1e1b313
@Dubjunk
changed defaultvalue
18693c4
@Dubjunk
bugfix + additions to the dynamic dialog creation
80bcab5
@Dubjunk
Added new changePermission function
80e9dad
@Dubjunk
typo
0248123
Wyqer
Wyqer requested changes Dec 28, 2018
View reviewed changes
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically it looks fine on a first overview without a real test in the game.
Some small things to shorten the code or get rid of unnecessary variables.
In general I guess there could be something to optimize in a later stage or as soon as others adding persmission to it, but for now the commented stuff is all I've found so far.
Thanks for the work 👍

Missionframework/modules/11_permission/fnc/fn_permission_changePermission.sqf Outdated Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_changePermission.sqf Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_changePermission.sqf Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_checkPermission.sqf Outdated Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_checkVehiclePermission.sqf Outdated Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_syncClients.sqf Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Wyqer
Wyqer previously approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small stuff again, but overall lgtm.

Missionframework/modules/11_permission/fnc/fn_permission_changePermission.sqf Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_changePermission.sqf Outdated Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_changePermission.sqf Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_checkVehiclePermission.sqf Outdated Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_setupPlayerActions.sqf Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Missionframework/modules/11_permission/fnc/fn_permission_addPermissionHandler.sqf Show resolved Hide resolved
veteran29
veteran29 approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overally lgtm, everything worth mentioning was already mentioned by Wyqer.

Missionframework/modules/11_permission/fnc/fn_permission_setupPermissionControls.sqf Outdated Show resolved Hide resolved
@Dubjunk Dubjunk merged commit 5cbbec4 into v0.97S9 Dec 30, 2018
@Dubjunk Dubjunk deleted the v0.97S9-541 branch December 30, 2018 16:49
@Wyqer Wyqer mentioned this pull request Jan 1, 2019
Closed
@Wyqer Wyqer added done and removed review/QA labels May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyqer Wyqer Wyqer approved these changes

@veteran29 veteran29 veteran29 approved these changes

Assignees

@Dubjunk Dubjunk

Labels
None yet
Projects
None yet
Milestone
Sprint 9
Development

Successfully merging this pull request may close these issues.
3 participants
@Dubjunk @Wyqer @veteran29