Enemy module pt1 #566
Merged
Enemy module pt1 #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!DEBUG! !TODO! !NOTE!
Dubjunk
reviewed
Feb 24, 2019
| // Handle requested infantry | ||
| if !(_troops > (_garrison select 2)) then { | ||
| // Define one infantry squad for transport | ||
| private _squadComp = [ |
There was a problem hiding this comment.
We should provide some more immersive groups in a later stage.
Leader
Medic
AA/AT
MG
...
There was a problem hiding this comment.
This is just for moving amount of infantry from A to B.
For "battlegroups" or similar it'll be dynamic like in the old framework.
veteran29
reviewed
Feb 24, 2019
| // Check via config for enough transport seats and return resulting array | ||
| private _validVeh = []; | ||
| { | ||
| if ((getNumber (configfile >> "CfgVehicles" >> _x >> "transportSoldier")) >= _amount) then { |
There was a problem hiding this comment.
Config lookups are performance costly, it could be saved in some namespace, take a look at KPLIB_fnc_common_getIcon
There was a problem hiding this comment.
I'll have a speed check for pt2 and adjust it, if it's a huge improvement. 👍
Dubjunk
reviewed
Feb 24, 2019
Dubjunk
approved these changes
Feb 24, 2019
veteran29
approved these changes
Feb 24, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As stated in the issue itself, this provides the first part of the enemy module to provide a basic foundation for the future iterations. The currently implemented functions to transfer garrisons can be tested via the debug console.
Example for transfering units from the Feres Outpost military base to Feres:
There is still some rare occurances of "vehicle spawn explosion", even if there is always a "is something already there" check. My assumption is, that it's caused by the fact that we keep calling the spawning, so it maybe can't recognize it sometimes, that there is a vehicle spawned directly before the current one. Would be interesting to test this in the next sprint and maybe find a way to have it running in a capsuled scheduled environment. Reason for this assumption is, that the spawning in general is handled like in the old framework. The only real difference is the (un-)scheduled environment where the spawning happen.
Furthermore this PR contains smaller tweaks outside of the module and a example module structure as template for creating new modules.
Content:
Successfully tested on:
Compatibility checked with: