Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logistic module pt1 #567

Merged
merged 27 commits into from
Feb 24, 2019
Merged

Logistic module pt1 #567

merged 27 commits into from
Feb 24, 2019

Conversation

Dubjunk
Copy link
Contributor

@Dubjunk Dubjunk commented Feb 24, 2019

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues #533

Description:

This PR provides the first part of the Logistic Station.
With the new Framework you can create and add your own dialogs to the Station.

For now you've the Main Menu, the Recycle dialog and the Resupply dialog

In the resupply dialog could occur some locality problems with some commands, This needs to be checked later.

Content:

  • Add building to the preset
  • Create "Choice menu"
  • Create Resupply Dialog
  • Create Recycle Dialog
  • Evaluate if there is a possibility to provide a kind of "addLogisticMenuOption" function which adds a button on the list, so other modules could provide their functionalities from the logistic menu.

Successfully tested on:

  • Local MP Vanilla
  • Dedicated MP Vanilla

Compatibility checked with:

  • ACE

@Dubjunk Dubjunk added this to the Sprint 10 milestone Feb 24, 2019
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks fine and like a good first iteration for the module.
During the test phase by the community or our own further work there will be of course some small things which we haven't catched now, but these could be adressed easily in the next iteration.
👍

Missionframework/modules/23_logistic/functions.hpp Outdated Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
Missionframework/stringtable.xml Outdated Show resolved Hide resolved
@Wyqer Wyqer changed the title V0.97 s10 533 Logistic module pt1 Feb 24, 2019
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided my thoughts in comments.

@Dubjunk Dubjunk merged commit 9e19e33 into v0.97S10 Feb 24, 2019
@Dubjunk Dubjunk deleted the v0.97S10-533 branch February 24, 2019 19:52
@Wyqer Wyqer added done and removed review/QA labels Feb 24, 2019
@Wyqer Wyqer mentioned this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants