Support Ice 3.7 and Ubuntu 20.04 #74
Conversation
|
As requested, this PR has been squashed down before submission so it only contains two commits. I have tested this version on a clean installation of Ubuntu 20.04.3 and it operates correctly. I did not update the version number in this case, as I would rather leave that to the maintainer to decide the versioning. |
|
Awesome! I will broadly look over the changes a bit later, but overall trust you on them and their functioning. :) |
|
Yeah, sorry for the delay in getting the PR submitted with the squashed commits. Hopefully this revitalises the project and we can bring it up to date later with Mumble 1.4 once it goes stable. |
|
The second commit has a different author. I assume you want to use/get attributed with the first one; this github account? |
Kissaki
force-pushed
the
master
branch
3 times, most recently
from
4727636
to
f4f9c57
Compare
|
That's correct. AtomicHaggis. That other one was using a work account. |
Kissaki
force-pushed
the
master
branch
2 times, most recently
from
992fb7f
to
1489ab1
Compare
Co-authored-by: Jan Klass <[email protected]>
Update default configuration to use generated Murmur 1.3.0 with Ice 3.7 slice PHP code.
Co-authored-by: Jan Klass <[email protected]>
Change type references to backslash syntax Update ServerInterface.php Ice initialization. Drop Ice 3.3 and 3.4 initialization.
|
I split the changes into logical commits. The changes look good to me. I changed the ice extension loaded and version check a bit, which you can see in 286939f. Can you please test this resulting state works? |
|
Yep, no problem. I'll grab it and test it in the morning. |
|
Work's been pretty hectic. I'll try to get to this tomorrow. |
|
@AtomicHaggis Will you be able to test it soon(ish)? Otherwise I will merge it as-is. |
|
@Kissaki Life's been a bit chaotic! I'll get to testing it this weekend. I'll let you know on Sunday. |
Kissaki
changed the title
Kissaki
changed the title
|
I am merging it as-is :) and will tag a release version |
This pull request includes all changes and updates to MumPi to support newer operating systems such as Ubuntu 18.04 and 20.04. Since older versions of Ubuntu are no longer supported, support for obsolete versions of Mumble below 1.3.0 have been removed.