Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global keyword reassignment #265

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

greg-kcio
Copy link
Contributor

The black formatter was unable to process the global class, so it will be renamed to global_.

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kittycad-py ✅ Ready (Inspect) Visit Preview Sep 10, 2024 2:46pm

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.79%. Comparing base (d2e9b0b) to head (81ec071).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   60.65%   60.79%   +0.13%     
==========================================
  Files         412      412              
  Lines       11770    11770              
==========================================
+ Hits         7139     7155      +16     
+ Misses       4631     4615      -16     
Flag Coverage Δ
unittests 60.79% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greg-kcio greg-kcio merged commit f22663c into main Sep 10, 2024
6 of 9 checks passed
@greg-kcio greg-kcio deleted the greg/fix-global-keyword-reassignment branch September 10, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant