functions that operation on a tag should not require the %

[jessfraz]

One thing that annoys me about tags now that they are high level is they should map directly back to the uuid in engine so like getNextAdjacentEdge(bs.tags.edge7, %) should just be getNextAdjacentEdge(bs.tags.edge7) like you should not need the %

part of #2941 and making tags high level functions

• autocomplete tags on a sketch group/member expressions in the lsp #2943
• remove getEdge
• remove backwards compatibility for functions that operate on a tag should not require % #3144

[Irev-Dev]

Yes, I agree! (and @max-mrgrsk will too)

It makes it much more cumbersome to use, I know you mentioned the %, but I would assert that having to include the variable and the tag is less of a pain within the same pipeExpression with the % when compared to matching up a tag and some other variable as can be the case for sketchOnFace, will also make the AstMods much easier since we don't need to track down the exact right variable to slot in.

Feels like a win on all fronts.

[max-mrgrsk]

totally agree! super nice idea and it looks so much cleaner

[jessfraz]

yeah I started on a PR for this, its going to be a bit because its more involved than i realized , it will get there but ill do it in small changes lol

[jtran]

Can someone explain this to me? getNextAdjacdntEdge() uses the extrude group.

modeling-app/src/wasm-lib/kcl/src/std/fillet.rs

Lines 283 to 292 in 6e7e6e9

	let tagged_path = extrude_group
	.sketch_group
	.get_path_by_tag(&tag)
	.ok_or_else(|| {
	KclError::Type(KclErrorDetails {
	message: format!("No edge found with tag: `{}`", tag.value),
	source_ranges: vec![args.source_range],
	})
	})?
	.get_base();

Are you saying that we can skip this step using only the tag and prior information?

I also want to make sure that we're not breaking the rule that the pipe operator is syntax sugar to convert this:

a |> b(%) |> c(%) |> d(%)

to this:

d(c(b(a)))

[jessfraz]

it will make this:

const width = 20
const length = 10
const thickness = 1
const chamferLength = 2

const mountingPlateSketch = startSketchOn("XY")
  |> startProfileAt([-width / 2, -length / 2], %)
  |> lineTo([width / 2, -length / 2], %, $edge1)
  |> lineTo([width / 2, length / 2], %, $edge2)
  |> lineTo([-width / 2, length / 2], %, $edge3)
  |> close(%, $edge4)

const mountingPlate = extrude(thickness, mountingPlateSketch)
  |> chamfer({
       length: chamferLength,
       tags: [
         getNextAdjacentEdge(edge1, %),
         getNextAdjacentEdge(edge2, %),
         getNextAdjacentEdge(edge3, %),
         getNextAdjacentEdge(edge4, %)
       ]
     }, %)

be this:

const width = 20
const length = 10
const thickness = 1
const chamferLength = 2

const mountingPlateSketch = startSketchOn("XY")
  |> startProfileAt([-width / 2, -length / 2], %)
  |> lineTo([width / 2, -length / 2], %, $edge1)
  |> lineTo([width / 2, length / 2], %, $edge2)
  |> lineTo([-width / 2, length / 2], %, $edge3)
  |> close(%, $edge4)

const mountingPlate = extrude(thickness, mountingPlateSketch)
  |> chamfer({
       length: chamferLength,
       tags: [
         getNextAdjacentEdge(edge1),
         getNextAdjacentEdge(edge2),
         getNextAdjacentEdge(edge3),
         getNextAdjacentEdge(edge4)
       ]
     }, %)

not changing the behvior of pipes