Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag enhancements #3143

Merged
merged 30 commits into from
Jul 28, 2024
Merged

Tag enhancements #3143

merged 30 commits into from
Jul 28, 2024

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Jul 28, 2024

closes #2942

this is still backwards compatible, but we should remove that later

cc @greg-kcio @jgomez720 @r-barton @nicboone8

now functions like getPreviousEdge only have one argument, the tag. Makes it much simpiler, check the docs for details on which functions changed

  • add a lint rule for when you have too many args in a stdlib fn that says it will in the future fail

Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Copy link

qa-wolf bot commented Jul 28, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jul 28, 2024 5:29am

jessfraz and others added 5 commits July 27, 2024 20:43
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

1 similar comment
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 85.30466% with 41 lines in your changes missing coverage. Please review.

Project coverage is 87.96%. Comparing base (6e2dd53) to head (3e11e10).
Report is 1 commits behind head on main.

Files Patch % Lines
src/wasm-lib/kcl/src/std/args.rs 60.31% 25 Missing ⚠️
src/wasm-lib/kcl/src/std/sketch.rs 86.56% 9 Missing ⚠️
src/wasm-lib/kcl/src/ast/types.rs 90.32% 6 Missing ⚠️
src/wasm-lib/kcl/src/executor.rs 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3143      +/-   ##
==========================================
+ Coverage   87.75%   87.96%   +0.20%     
==========================================
  Files          64       64              
  Lines       24892    24809      -83     
==========================================
- Hits        21845    21822      -23     
+ Misses       3047     2987      -60     
Flag Coverage Δ
wasm-lib 87.96% <85.30%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

1 similar comment
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz jessfraz enabled auto-merge (squash) July 28, 2024 05:35
@jessfraz jessfraz merged commit fb7b2be into main Jul 28, 2024
22 of 23 checks passed
@jessfraz jessfraz deleted the tag-enhancements branch July 28, 2024 05:56
@franknoirot franknoirot mentioned this pull request Jul 30, 2024
jessfraz added a commit that referenced this pull request Jul 31, 2024
* start

Signed-off-by: Jess Frazelle <[email protected]>

* updates

Signed-off-by: Jess Frazelle <[email protected]>

* updates

Signed-off-by: Jess Frazelle <[email protected]>

* more

Signed-off-by: Jess Frazelle <[email protected]>

* enhancements

Signed-off-by: Jess Frazelle <[email protected]>

* updates

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* get plane data

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* updates

Signed-off-by: Jess Frazelle <[email protected]>

* updates

Signed-off-by: Jess Frazelle <[email protected]>

* cleanup

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* more

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* updates

Signed-off-by: Jess Frazelle <[email protected]>

* fmt

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* updates

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* add lint rule

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

* fixes

Signed-off-by: Jess Frazelle <[email protected]>

---------

Signed-off-by: Jess Frazelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

functions that operation on a tag should not require the %
1 participant